[4.17] Add happy path validation coverage for the MCG guaranteed bucket logs feature #10228
+867
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
701bfa4
to
e33c8a9
Compare
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
e33c8a9
to
9aa11c4
Compare
pull-request-size
bot
added
size/XL
and removed
size/L
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
9aa11c4
to
2955369
Compare
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
2955369
to
d21e8c4
Compare
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
d21e8c4
to
dec2c01
Compare
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
dec2c01
to
3ec7573
Compare
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
3ec7573
to
ba62167
Compare
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
2 times, most recently
from
7c437f7
to
8794829
Compare
Signed-off-by: Sagi Hirshfeld <[email protected]>
sagihirshfeld
force-pushed
the
test-guaranteed-nb-logs
branch
from
8794829
to
3376a44
Compare
ocs-ci
reviewed
Sep 17, 2024
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: shirshfe-417ibm34
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_logs.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Sagi Hirshfeld <[email protected]>
Signed-off-by: Sagi Hirshfeld <[email protected]>
ocs-ci
reviewed
Sep 17, 2024
ocs-ci
reviewed
Sep 17, 2024
Signed-off-by: Sagi Hirshfeld <[email protected]>
ocs-ci
reviewed
Sep 18, 2024
Signed-off-by: Sagi Hirshfeld <[email protected]>
Signed-off-by: Sagi Hirshfeld <[email protected]>
Signed-off-by: Sagi Hirshfeld <[email protected]>
ocs-ci
reviewed
Sep 23, 2024
OdedViner
approved these changes
Oct 13, 2024
OdedViner
previously approved these changes
Oct 13, 2024
DanielOsypenko
previously approved these changes
Oct 13, 2024
Signed-off-by: Sagi Hirshfeld <[email protected]>
sagihirshfeld
dismissed stale reviews from DanielOsypenko and OdedViner
via
19cea6f
Signed-off-by: Sagi Hirshfeld <[email protected]>
DanielOsypenko
approved these changes
Oct 13, 2024
OdedViner
approved these changes
Oct 13, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, OdedViner, sagihirshfeld The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new tests to cover https://url.corp.redhat.com/743e5e0 - the guaranteed bucket logs feature on MCG:
test_guaranteed_bucket_logs_management: test enabling, checking the status, and disabling the feature at both the CR level and on a pair of buckets: source-bucket and logs-bucket.test_bucket_logs_integrity: test that all the expected S3 operations on a source-bucket are logged as expected on its logs-bucketThis PR also adds the needed utilities and fixtures to support these tests:
BucketLoggingManagerclass holds all the necessary util functions for configuring and validating the featureenable_guaranteed_bucket_loggingfixture uses the above to enable the feature on the CR level, with the proper cleanup that's needed at teardown.