Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2315651:[release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec #212

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #211

/assign leelavg

all components deployed as part of odf should tolerate this taint by
default "node.ocs.openshift.io/storage=true:NoSchedule"

part of https://bugzilla.redhat.com/show_bug.cgi?id=2315651

Signed-off-by: Leela Venkaiah G <[email protected]>
Copy link

openshift-ci bot commented Oct 4, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: leelavg.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #211

/assign leelavg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@leelavg
Copy link

leelavg commented Oct 4, 2024

/retitle Bug 2315651:[release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec

@openshift-ci openshift-ci bot changed the title [release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec Bug 2315651:[release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec Oct 4, 2024
Copy link

openshift-ci bot commented Oct 4, 2024

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2315651, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2315651:[release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 4, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2315651, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2315651:[release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit de9c641 into red-hat-storage:release-4.17 Oct 4, 2024
12 checks passed
Copy link

openshift-ci bot commented Oct 4, 2024

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2315651 has been moved to the MODIFIED state.

In response to this:

Bug 2315651:[release-4.17] [DOWNSTREAM-ONLY] add ocs default toleration to controller podspec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants