Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from main for kubernetes-csi-addons #131

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from main branch

nixpanic and others added 2 commits April 1, 2024 06:11
With Go 1.21 the "slices" package can be used for many operations on
slices. The custom ContainsInSlice() function can be replaced by the
standard slices.Contains().

Signed-off-by: Niels de Vos <[email protected]>
Syncing latest changes from upstream main for kubernetes-csi-addons
@df-build-team df-build-team requested a review from a team April 3, 2024 09:59
Copy link

openshift-ci bot commented Apr 3, 2024

@df-build-team: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Syncing latest changes from main for kubernetes-csi-addons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

nixpanic commented Apr 3, 2024

/lgtm
/approve

This can be included in release-4.16, but there is no strong need for it. Backports now require valid bugs, and we don't have one for rebasing.

Copy link

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 3, 2024
@nixpanic
Copy link
Member

nixpanic commented Apr 4, 2024

/label bugzilla/valid-bug

Copy link

openshift-ci bot commented Apr 4, 2024

@nixpanic: Can not set label bugzilla/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to this:

/label bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

nixpanic commented Apr 4, 2024

This is the last sync-pr for release-4.16 coming from the automation. Because 4.16 testing was done on the main branch until now, the branches need to be insync to prevent missing commits.

@openshift-merge-bot openshift-merge-bot bot merged commit 1ab1d98 into release-4.16 Apr 4, 2024
24 checks passed
@Nikhil-Ladha Nikhil-Ladha deleted the sync_ds--main branch May 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants