Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for kubernetes-csi-addons #124

Merged
merged 2 commits into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. vendor: bump the github-dependencies group in /tools with 1 update

    Bumps the github-dependencies group in /tools with 1 update: [github.com/operator-framework/operator-sdk](https://github.com/operator-framework/operator-sdk).
    
    
    Updates `github.com/operator-framework/operator-sdk` from 1.33.0 to 1.34.0
    - [Release notes](https://github.com/operator-framework/operator-sdk/releases)
    - [Changelog](https://github.com/operator-framework/operator-sdk/blob/master/.goreleaser.yml)
    - [Commits](operator-framework/operator-sdk@v1.33.0...v1.34.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/operator-framework/operator-sdk
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: github-dependencies
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and mergify[bot] committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9f28afe View commit details
    Browse the repository at this point in the history
  2. ci: fix TestGetNextSchedule failure

    The test case was failing if the test was run at some particular
    time of the day.
    
    For ex: If the test was triggered @0:15:0, the last scheduled time
    will be 23:15:0 of the previous day since we are setting it to an
    hour earlier than the current time. Now when we calculate the
    getNextSchedule, the next schedule will point to the current day,
    when the cron job is scheduled to run at midnight every day. So
    in this case, the lastMissed will be pointing to a valid time.
    This leads to some test cases to get unexpected value for the
    lastMissed time which expects it to be time.Time{}. Though we get
    the expected wantErr in such cases too, since we are comparing the
    other return values seperately.
    
    To avoid such failures, this patch checks for multiple expected
    last scheduled times.
    Also the last scheduled time is aligned with the cron job schedule
    to keep it relative.
    
    Signed-off-by: karthik-us <[email protected]>
    karthik-us authored and mergify[bot] committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    61a0350 View commit details
    Browse the repository at this point in the history