Syncing latest changes from upstream main for kubernetes-csi-addons #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the following options:
-leader-election-lease-duration duration
Duration, in seconds, that non-leader candidates will wait to
force acquire leadership. Defaults to 15 seconds. (default 15s)
-leader-election-renew-deadline duration
Duration, in seconds, that the acting leader will retry
refreshing leadership before giving up. Defaults to 10 seconds.
(default 10s)
-leader-election-retry-period duration
Duration, in seconds, the LeaderElector clients should wait
between tries of actions. Defaults to 5 seconds. (default 5s)
Some container platforms (like OpenShift) have recommendations for these
timeout that differ from the Kubernetes defaults. With these options,
deployments can define the timeouts according to their own preferences.
Signed-off-by: Niels de Vos <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream main branch