Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add use_quay_for_containers to ProductVersion render output" #247

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

rhjostone
Copy link
Collaborator

This reverts commit d5e3fa2.

use_quay_for_containers does not appear to be used anymore in the Errata Tool API so we should remove it.

@rhjostone
Copy link
Collaborator Author

/approve

Copy link

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhjostone

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhjostone rhjostone merged commit 0b06d03 into master Nov 16, 2023
6 of 7 checks passed
@rhjostone rhjostone deleted the use-quay-for-containers branch November 16, 2023 19:37
@ktdreyer
Copy link
Member

Looks like we need to update errata_tool/tests/fixtures/errata.devel.redhat.com/api/v1/products/RHACM/product_versions to account for the use_quay_for_containers removal.

./new-fixture.sh https://errata.devel.redhat.com/api/v1/products/RHACM/product_versions

Unfortunately this breaks the unit tests because they depend on RHEL-7-RHACM-1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants