release: always assign name from server data
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktdreyer
force-pushed
the
release-name-by-id
branch
from
a1a9e75
to
eff2697
Compare
Prior to this change, if a user created a Release class by specifying an ID number instead of a name string, the class would always set the name property to None. For example, this would be None: Release(id=1234).name Assign name when we process all the other data attributes in _setattr().
ktdreyer
force-pushed
the
release-name-by-id
branch
from
eff2697
to
c102cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if a user created a
Releaseclass by specifying an ID number instead of anamestring, the class would always set thenameproperty toNone. For example, this would beNone:Assign
namewhen we process all the other data attributes in_setattr().