Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CEPH-11209 with rgw_torrent_flag #637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TejasC88
Copy link
Contributor

@TejasC88 TejasC88 commented Oct 8, 2024

Script : https://github.com/red-hat-storage/ceph-qe-scripts/blob/master/rgw/v2/tests/s3_swift/test_policy_torrent.py

We had an issue with getting torrent for files with BZ https://bugzilla.redhat.com/show_bug.cgi?id=2299815
The BZ is now closed , and the feature is working as expected.

We need to add a config option to enable rgw_torrent_flag , which will allow torrents to be generated.

Pass log : http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/torrent_pass_log.txt

rgw_service_name = utils.exec_shell_cmd("ceph orch ls | grep rgw").split(" ")[0]
utils.exec_shell_cmd(
f"ceph config set client.{rgw_service_name} rgw_torrent_flag true"
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TejasC88
don't we need rgw restart after this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmaheswa I had missed this , but somehow the config is taken without a restart also . Let me add a restart just in case , thanks.

@TejasC88
Copy link
Contributor Author

TejasC88 commented Oct 8, 2024

@hmaheswa added a RGW restart , updated pass log : http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/torrent_pass_log.txt , pls review

@TejasC88 TejasC88 requested review from hmaheswa and a team October 8, 2024 11:18
Copy link
Contributor

@ckulal ckulal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anrao19 anrao19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Oct 11, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anrao19, TejasC88

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me RGW RGW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants