Syncing latest changes from upstream devel for ceph-csi #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated GetVolumeByID to return more descriptive error so that caller no need to add more details in the error message. Signed-off-by: Madhu Rajanna <[email protected]>
implement journalledObject interface to return the journal objects of the volume. Signed-off-by: Madhu Rajanna <[email protected]>
This commit adds support for flattenMode option for volumegroup. If the flattenMode is set to "force" in volumegroupreplicationclass parameters, cephcsi will add a task to flatten the image if it has parent before adding it to the group. This enable cephcsi to then mirror such images after flattening them. Signed-off-by: Madhu Rajanna <[email protected]>
updating HandleParentImageExistence function to return more details error which includes the pool/namespace/image name Signed-off-by: Madhu Rajanna <[email protected]>
updating csiaddons spec to the latest main. Signed-off-by: Madhu Rajanna <[email protected]>
in ModifyVolumeGroupMembership RPC call, flatten the required images before adding it to the group or else if the parent is not mirror enabled adding a child to the group will fail. Signed-off-by: Madhu Rajanna <[email protected]>
GetVolumeByID already returning detailed error message, the caller just need to return it. No need to add duplicate details to error message. Signed-off-by: Madhu Rajanna <[email protected]>
adding required ctx to the mirror interface as ctx is required for the volumegroup operations. Signed-off-by: Madhu Rajanna <[email protected]>
updated the group stringer method to have pool and namespace for proper debugging/logging and to use it with CLI as agrument as well. Signed-off-by: Madhu Rajanna <[email protected]>
updated GetIDFromReplication to return volumeGroupID if its present. Signed-off-by: Madhu Rajanna <[email protected]>
The Squid container-image that is used as base for the Ceph-CSI container-image uses CentOS Stream 9. Closes: ceph#4659 Signed-off-by: Niels de Vos <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch