Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing latest changes from upstream devel for ceph-csi #337

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Syncing latest changes from upstream devel for ceph-csi #337

merged 3 commits into from
Jul 11, 2024

Commits on Jul 10, 2024

  1. rebase: Bump github.com/container-storage-interface/spec 

    Bumps [github.com/container-storage-interface/spec](https://github.com/container-storage-interface/spec) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/container-storage-interface/spec/releases)
- [Commits](container-storage-interface/spec@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/container-storage-interface/spec
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot @mergify
    dependabot[bot] authored and mergify[bot] committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    786414b View commit details
    Browse the repository at this point in the history

  2. util: DefaultIdentityServer should use csi.UnimplementedIdentityServer 

    The DefaultIdentityServer struct embedded UnimplementedControllerServer,
but it should have been UnimplementedIdentityServer instead.

Signed-off-by: Niels de Vos <[email protected]>
    @nixpanic @mergify
    nixpanic authored and mergify[bot] committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    69ef70e View commit details
    Browse the repository at this point in the history

  3. cleanup: append pointer instead of value to avoid copying lock value 

    This commit resolves the govet issue -
`copylocks: call of append copies lock value ... contains sync.Mutex`

Embedding DoNotCopy in a struct is a convention to signal and prevent
shallow copies, as recommended in Go's best practices. This does not
rely on a language feature but is instead a special case within the vet
checker.

For more details, see https://golang.org/issues/8005

Signed-off-by: Praveen M <[email protected]>
    @iPraveenParihar @mergify
    iPraveenParihar authored and mergify[bot] committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d376271 View commit details
    Browse the repository at this point in the history