-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing latest changes from devel for ceph-csi #306
Conversation
The tests are failing due to missing ruby-devel package in the base image Signed-off-by: Madhu Rajanna <[email protected]>
updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The link on the README file to get an invite to the Ceph Slack was missing a URL scheme, so it was interpreted as a relative link and resulted in a 404. Signed-off-by: Ben Tullis <[email protected]>
Signed-off-by: Mike Perez <[email protected]>
@df-build-team am not sure how this PR is created, because the commits listed in this PR are still not present in the downstream devel branch yet, they are waiting to get merged #305. |
Bumps the k8s-dependencies group with 1 update in the / directory: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `sigs.k8s.io/controller-runtime` from 0.17.3 to 0.18.2 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.3...v0.18.2) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
dropping go version from the go mod as we have x.y.z version for go Signed-off-by: Madhu Rajanna <[email protected]>
updating kubernetes to 1.30 release Signed-off-by: Madhu Rajanna <[email protected]>
update kubernetes and go version in api folder. Signed-off-by: Madhu Rajanna <[email protected]>
changes as per new controller runtime import Signed-off-by: Madhu Rajanna <[email protected]>
fixing logging as per new controller runtime errors Signed-off-by: Madhu Rajanna <[email protected]>
Signed-off-by: Praveen M <[email protected]>
@Madhu-1 it seems that the commits in this PR are merged in the devel branch now? Maybe @Nikhil-Ladha can explain the process how the backport to a release-4.x branch is done, and how/when the |
yes that true. it got merged later. unblocking this one for now. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The sync to It syncs the commit from devel/main to the release-4.x branch. |
@Nikhil-Ladha that was my expectation as well but that's not the case, even as the changes are not merged to devel branch got added to the release-4.17 branch as well. |
Oh ok, in that case it seems they are using upstream devel. |
PR containing the latest commits from devel branch