Syncing latest changes from upstream devel for ceph-csi #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that original commit 4c2d2ca modified the API under the vendor/ directory. Weirdly this did not cause any issues?! The change should have been done in the api/deploy/kubernetes/ file instead, that gets sync'd after running "go mod vendor". Signed-off-by: Niels de Vos <[email protected]>
Kubernetes 1.26 is End-Of-Life, the next version of Ceph-CSI will not support that anymore. Signed-off-by: Niels de Vos <[email protected]>
It seems GitHub has an issue with the Fedora 40 container image, extracting the Golang tarball fails. The Fedora 39 image does not have this problem, so use that for the time being. Signed-off-by: Niels de Vos <[email protected]>
|
ceph#4584 fixes the GitHub CI runs, it should get included in the next update (tomorrow?) for this PR. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch