Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2225436: rbd: do not execute rbd sparsify when volume is in use #182

Closed
wants to merge 1 commit into from

Conversation

yati1998
Copy link
Member

This is a backport PR.
This commit makes sure sparsify() is not run when rbd image is in use.
Running rbd sparsify with workload doing io and too frequently is not desirable.
When a image is in use fstrim is run and sparsify will be run only when image is not mapped.

This is a backport PR.
This commit makes sure sparsify() is not run when rbd
image is in use.
Running rbd sparsify with workload doing io and too
frequently is not desirable.
When a image is in use fstrim is run and sparsify will
be run only when image is not mapped.

Signed-off-by: Yati Padia <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@yati1998: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

rbd: do not execute rbd sparsify when volume is in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Aug 29, 2023
@yati1998 yati1998 changed the title rbd: do not execute rbd sparsify when volume is in use BUG 2225436: rbd: do not execute rbd sparsify when volume is in use Aug 29, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@yati1998: This pull request references Bugzilla bug 2225436, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

BUG 2225436: rbd: do not execute rbd sparsify when volume is in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@yati1998: This pull request references Bugzilla bug 2225436, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.3) matches configured target release for branch (ODF 4.13.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

BUG 2225436: rbd: do not execute rbd sparsify when volume is in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Aug 29, 2023

@yati1998 please use git cherry-pick -x to cherry-pick a commit

@Madhu-1
Copy link
Member

Madhu-1 commented Aug 29, 2023

Closing as we created #183

@Madhu-1 Madhu-1 closed this Aug 29, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@yati1998: This pull request references Bugzilla bug 2225436. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

BUG 2225436: rbd: do not execute rbd sparsify when volume is in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants