Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Download Pipeline Example #875

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Upload Download Pipeline Example #875

merged 2 commits into from
Aug 25, 2023

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Aug 16, 2023 •
edited
Loading

Automated test for: opendatahub-io/data-science-pipelines-operator#228

Verify Ods Users Can Create And Run A Data Science Pipeline Using ... | PASS |
------------------------------------------------------------------------------
Tests.Ods Dashboard.Data Science Pipelines.Data-Science-Pipelines-... | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests.Ods Dashboard.Data Science Pipelines                            | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests.Ods Dashboard                                                   | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests                                                                 | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Output:  /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-16-10-15-pXoGtsYNcQ/output.xml
XUnit:   /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-16-10-15-pXoGtsYNcQ/xunit_test_result.xml
Log:     /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-16-10-15-pXoGtsYNcQ/log.html
Report:  /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-16-10-15-pXoGtsYNcQ/test_report.html

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2023
View reviewed changes
...ests/400__ods_dashboard/430__data_science_pipelines/432__data-science-pipelines-tekton.robot

... python_file=flip_coin.py
... method_name=flipcoin_pipeline
End To End Pipeline Workflow Using Kfp_tekton

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'End To End Pipeline Workflow Using Kfp_tekton' does not follow case convention
...ests/400__ods_dashboard/430__data_science_pipelines/432__data-science-pipelines-tekton.robot

... python_file=flip_coin.py
... method_name=flipcoin_pipeline
End To End Pipeline Workflow Using Kfp_tekton

Check warning

Code scanning / Robocop

Underscores in keyword name '{{ keyword_name }}' can be replaced with spaces Warning test

Underscores in keyword name 'End To End Pipeline Workflow Using Kfp_tekton' can be replaced with spaces
jgarciao
jgarciao reviewed Aug 22, 2023
View reviewed changes
ods_ci/libs/DataSciencePipelinesAPI.py
@@ -289,6 +296,14 @@ def retrieve_auth_url(self):
# host[4:] means that we need to remove '.api' from the url
return f"https://oauth-openshift.apps.{host[4:]}/oauth/authorize?response_type=token&client_id=openshift-challenging-client"

def get_default_storage(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keyword is not related to pipelines. I think it could be added to ods_ci/tests/Resources/OCP.resource or ods_ci/tasks/Resources/Provisioning/Hive/provision.robot (there is already a Set Cluster Storage kw)

poetry.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this PR is modifying poetry.lock, even if it's just for kfp-tekton, could you run all the Smoke pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think https://jenkins/job/rhods-smoke/3117/TestReport/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tests failed but I think it was unrelated to this changes. Ok for me

@jgarciao jgarciao self-requested a review August 22, 2023 11:10
@bdattoma
Copy link
Contributor

@diegolovison could you plz check the security scan result?

@diegolovison
Copy link
Contributor Author

@diegolovison could you plz check the security scan result?

Make sure publicly writable directories are used safely here.

writing to tmp looks fine to me

@diegolovison diegolovison merged commit 246e5fe into red-hat-data-services:master Aug 25, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarciao jgarciao jgarciao approved these changes

@lugi0 lugi0 lugi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diegolovison @bdattoma @jgarciao @lugi0