Modified 2 files to update newsrec model #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumana sree <[email protected]>
sumana-2705
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
miguelgfierro
merged commit ae2338c
into
recommenders-team:staging
1 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have modified the file,
base_model.pyin which I added a parameter named step_limit(which is optional) into the funtionfitand also modified the filetest_newsrec_model.py, I have adjusted step_limit=1 which speeds up the smoke test.Related Issues
It fixes the issue #2044
References
I have done changes as mentioned in the issue
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.