Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support steps to newsrec models #2044

Open
loomlike opened this issue Dec 19, 2023 · 5 comments
Open

[FEATURE] Support steps to newsrec models #2044

loomlike opened this issue Dec 19, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@loomlike
Copy link
Collaborator

Description

Currently newsrec models only support epoch training and the smoke-tests with epoch = 1 take minutes for each notebook.
With a simple tweak to base_model.fit(), we can introduce steps parameters that constraint the number of batches to train.
Then, we can set steps = 1 to the smoke test which will expediate the test time.

Expected behavior with the suggested feature

Use steps = 1 to all the smoke tests of the newsrec models.

@loomlike loomlike added the enhancement New feature or request label Dec 19, 2023
@sumana-2705
Copy link

@loomlike @miguelgfierro
Shall I work on this issue?

@miguelgfierro
Copy link
Collaborator

feel free

@sumana-2705
Copy link

@miguelgfierro I have opened a pr, but most of the checks have failed. I am not able to understand what is the reason for it. Can you please explain me why it happens, so that I can correct those checks.

@miguelgfierro
Copy link
Collaborator

right now, we have a bug that prevents external contributors from running the tests. It is a security limit from MS. We need to find a workaround. See #1853

@sumana-2705
Copy link

okayy, I understood. Thanks for your reply @miguelgfierro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants