Removed the unused getClientRectsPonyfill
#33
Conversation
oleksandr-danylchenko
changed the title
getClientRectsPonyfillgetClientRectsPonyfill
|
I'll leave this open for now. Need to revisit. The problem is that Firefox deals with highlight computation differently (in a bad way) as soon as block-level elements are involved. Leading to the following difference: Chrome (= the behavior we want)
Firefox (bad)
The ponyfill temporarily modifies the DOM, inserts SPANs, and then measures highlights from the SPANs rather than the Ranges. This is a pretty heavy computation, and occasionally introduces unwanted side effects on the Range object. Because of this, I currently disabled it. But it remains an open issue. |
|
That's crazy 🤯 |
# Conflicts: # packages/text-annotator/src/state/spatialTree.ts # packages/text-annotator/src/utils/index.ts
|
Seems like the Ponyfill introduces its own set of weird selection behaviors 😅 |
|
It's safe to say that we won't be using the ponyfill anymore. I removed it manually (rather than resolving the conflicts that have come up recently.) |
Changes Made
I noticed that since September the Firefox-specific handling for obtaining client rects has been deactivated. And if since then there were no issues w/ Firefox - I think that we can remove the unused ponyfill