#185 Fixed popup rendering on Android #186
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
See - #185 (comment)
In the #123 I made the popup presence check resilient to the underlying collapsed ranges in the target's selectors.
However, it caused a timing regression on Android. When the annotation is processed in the popup's
useEffect
, thetarget
and its bounds aren't yet populated.text-annotator-js/packages/text-annotator-react/src/TextAnnotationPopup/TextAnnotationPopup.tsx
Lines 95 to 98 in 5b9abad
Also, the timing of the selection change event that populates the
target
differs on Android:Changes Made
I added a check for the selectors' presence on the annotation's target. That way, the effect will react properly to their addition and re-run the bounds querying.