⚠️ Fixed accessing an obsolete isCollapsed value on pointerup handling ⚠️
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const stopPollingInMs = 50; | ||
| setTimeout(() => stopPolling = true, stopPollingInMs); | ||
|
|
||
| return poll(() => isCollapsed = sel?.isCollapsed, pollingDelayMs, shouldStopPolling); |
There was a problem hiding this comment.
The first call is immediate, which won't hold off desktop users, for which the isCollapsed: false is available immediately.
And for the rest of the cases, the polling will stop as soon as the range finally gets recognized as collapsed. However, to prevent endless polling and not make the experience sluggish, I limited it with 50ms. cap
oleksandr-danylchenko
force-pushed
the
fix-obsolete-collapsed-state
branch
from
1922b43 to
5d3a8a0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts
# Conflicts: # package-lock.json # packages/text-annotator/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Source - #136 (comment)
Changes Made
Instead, I introduced "polling" for the range's collapsed state! If the
timeDifferenceis smaller than theCLICK_TIMEOUTand therangeisn't collapsed - we start polling it for up to50ms.(to be extra cautious). So if the browser changes its state quicker - it won't be held off by a "blind" timeout.