#127 Made annotatingEnabled property reactive
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-danylchenko
force-pushed
the
#127-annotating-enabled-reactive
branch
from
dae32c7 to
da40d2c
Compare
Comment on lines
30
to
38
| const setAnnotatingEnabled = (enabled: boolean) => { | ||
| currentAnnotatingEnabled = enabled; | ||
| onSelectionChange.clear(); | ||
|
|
||
| if (!enabled) { | ||
| currentTarget = undefined; | ||
| lastPointerDown = undefined; | ||
| } | ||
| }; |
There was a problem hiding this comment.
We must clean the onSelectionChange debounced call to prevent it from running on obsolete values from the closure. Otherwise, the selectionchange event will still get processed in the deferred call, even though the currentAnnotatingEnabled became false.
There was a problem hiding this comment.
I wonder how crucial that is though. Would annotatingEnabled get called during a selection in practice? The normal use cases I would see is:
- Setting it once on page init (because the user is getting a page served in "read-only mode")
- "Locking a page" interactively, by the user clicking a "Lock" button. (In which case there wouldn't be a selection.)
# Conflicts: # packages/text-annotator-react/src/TextAnnotator.tsx # packages/text-annotator/src/SelectionHandler.ts
# See - sindresorhus/debounce#8. The debounced function has a strict context comparison that breaks when applied in the resize listener
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts
# Conflicts: # packages/text-annotator/src/TextAnnotator.ts
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts # packages/text-annotator/src/TextAnnotator.ts # packages/text-annotator/src/highlight/baseRenderer.ts
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts # packages/text-annotator/src/utils/index.ts
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts
# Conflicts: # packages/text-annotator/src/utils/index.ts
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts
# Conflicts: # packages/text-annotator/src/SelectionHandler.ts # packages/text-annotator/src/TextAnnotator.ts
# Conflicts: # packages/text-annotator/src/TextAnnotator.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #127
Changes Made
I made the
annotatingEnableda dynamic property that can receive values from the external sources via thesetAnnotatingEnabled(following the "API addition: method to change userSelectAction" example)