Merge pull request #155 from oleksandr-danylchenko/fix-previous-selec…

…tion-cleanup Added missing previous selection discard upon the new selection change
recogito · Oct 14, 2024 · 775f612 · 775f612
2 parents 9ce6e88 + d1dddc9
commit 775f612
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/text-annotator/src/SelectionHandler.ts b/packages/text-annotator/src/SelectionHandler.ts
@@ -149,6 +149,9 @@ export const SelectionHandler = (
      */
     if (store.getAnnotation(currentTarget.annotation)) {
       store.updateTarget(currentTarget, Origin.LOCAL);
+    } else {
+      // Proper lifecycle management: clear the previous selection first...
+      selection.clear();
     }
   });
 
@@ -206,7 +209,7 @@ export const SelectionHandler = (
         if (selected.length !== 1 || selected[0].id !== hovered.id) {
           selection.userSelect(hovered.id, evt);
         }
-      } else if (!selection.isEmpty()) {
+      } else {
         selection.clear();
       }
     };