Notes: .ASS support, Drag&Drop support #1762

RusAD32 · 2023-06-03T14:27:09Z

also fixes a bug from this old issue: #695 because it did reproduce for me and bothered my friends and me a lot.

I'm not proficient with C++ so the code is probably very janky, so sorry about that.

cfillion

Thanks! Some observation from a first glance:

Drag&drop should probably be only active when one of the three subtitles modes is active and the 'import' button is visible.

Drag&drop needs the WS_EX_ACCEPTFILES window extended style to be enabled on Linux/macOS. In sws_extension.rc:

 IDD_SNM_NOTES DIALOGEX 0, 0, 281, 125
 STYLE DS_SETFONT | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU |  WS_THICKFRAME
+EXSTYLE WS_EX_ACCEPTFILES

SnM/SnM_Notes.cpp

cfillion · 2023-06-03T20:45:36Z

SnM/SnM_Notes.cpp

+            if (ImportAdvancedSubStationFile(fn))
+                //JFB hard-coded undo label: _ct might be NULL (when called from a button)
+                //    + avoid trailing "..." in undo point name (when called from an action)
+                Undo_OnStateChangeEx2(NULL, __LOCALIZE("Import ass file","sws_DLG_152"), UNDO_STATE_ALL, -1);


Shouldn't 'ASS' be in uppercase here?

whatsnew.txt

SnM/SnM.h

SnM/SnM_Notes.cpp

…used btnImportAss member and cleanup whitespace

…first 1K chars of the name field when larger than one buffer

cfillion · 2024-02-04T14:02:33Z

I've been testing this for potential inclusion in v2.14. It seems too easy to make the parser crash or produce bad data.
Considering the presence of those bugs and the overall fragile-looking state of the parser code, I'm not confident in its robustness and correctness. Fixed some in 0ced4fe above, but I suspect there are others waiting to be found.

[Events]
Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
Dialogue: 0,0:00:00.98,0:00:01.02,handwriting,truncated,,

AppVeyorBot · 2024-04-22T11:23:29Z

✅ Build sws 1099-master completed (commit 044cc26e98 by @RusAD32)

Windows 64-bit

Windows 32-bit

macOS x86 64-bit

macOS x86 32-bit

macOS ARM 64-bit

Linux x86 64-bit

Linux x86 32-bit

Linux ARM 64-bit

Linux ARM 32-bit