-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] BR: Ensure anchored tempo envelope has set bpm #1738
Draft
frenchy64
wants to merge
8
commits into
reaper-oss:master
Choose a base branch
from
frenchy64:issue-1737-move-closest-grid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] BR: Ensure anchored tempo envelope has set bpm #1738
frenchy64
wants to merge
8
commits into
reaper-oss:master
from
frenchy64:issue-1737-move-closest-grid
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchy64
changed the title
Issue 1737 move closest grid
BR: Ensure anchored tempo envelope has set bpm
Feb 24, 2023
This comment was marked as outdated.
This comment was marked as outdated.
✅ Build sws 943-master completed (commit 47e9f91966 by @frenchy64) Windows 64-bitWindows 32-bit |
frenchy64
force-pushed
the
issue-1737-move-closest-grid
branch
from
February 24, 2023 21:14
ece4864
to
b1c96a6
Compare
frenchy64
changed the title
BR: Ensure anchored tempo envelope has set bpm
[WIP] BR: Ensure anchored tempo envelope has set bpm
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1737
EDIT: this problem is pervasive to many other SWS/BR commands, a more fundamental fix is probably needed. Any command that anchors to a tempo envelope point without bpm seems to have the "floating point" problem.
I just followed my nose, unclear if I broke any surrounding code because I didn't try it. I also did not pay attention to formatting, will fix that up before merging.
Demo: