-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): pin setuptools 70 #216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
added a commit
to tiborsimko/reana-workflow-engine-serial
that referenced
this pull request
Sep 2, 2024
Pin `setuptools` to the maximum version of 70 to allow working on Ubuntu 20.04 LTS based environments. (New versions of `setuptools` are not compatible.) Note that this fix is necessary only for the `maint-0.9` branches and the REANA 0.9 release series. In `master` we have switched to Ubuntu 24.04 LTS based environments and Python 3.12 and no pinning is necessary there.
tiborsimko
force-pushed
the
fix-setuptools
branch
from
September 2, 2024 16:17
7a6a0c7
to
84472ff
Compare
Alputer
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could successfully built the cluster and ran 4 workflows with different workflow engines.
Pin `setuptools` to the maximum version of 70 to allow working on Ubuntu 20.04 LTS based environments. (New versions of `setuptools` are not compatible.) Note that this fix is necessary only for the `maint-0.9` branches and the REANA 0.9 release series. In `master` we have switched to Ubuntu 24.04 LTS based environments and Python 3.12 and no pinning is necessary there.
tiborsimko
force-pushed
the
fix-setuptools
branch
from
September 3, 2024 12:22
84472ff
to
f94d003
Compare
tiborsimko
changed the title
chore(docker): pin setuptools 70
build(docker): pin setuptools 70
Sep 3, 2024
tiborsimko
added a commit
to tiborsimko/reana-workflow-engine-serial
that referenced
this pull request
Dec 3, 2024
chore(maint-0.9): release 0.9.4 (reanahub#193) build(python): bump shared REANA packages as of 2024-11-28 (reanahub#218) build(docker): pin setuptools 70 (reanahub#216) feat(tasks): allow Compute4PUNCH backend options (reanahub#210) Note: The merge commit removes the changes related to pinning `setuptools` to version 70, because this was only necessary for the `maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko
added a commit
to tiborsimko/reana-workflow-engine-serial
that referenced
this pull request
Dec 3, 2024
chore(maint-0.9): release 0.9.4 (reanahub#193) build(python): bump shared REANA packages as of 2024-11-28 (reanahub#218) build(docker): pin setuptools 70 (reanahub#216) feat(tasks): allow Compute4PUNCH backend options (reanahub#210) Note: The merge commit removes the changes related to pinning `setuptools` to version 70, because this was only necessary for the `maint-0.9` branches, as well as other 0.9.4 release-related changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin
setuptools
to the maximum version of 70 to allow working on Ubuntu 20.04 LTS based environments. (New versions ofsetuptools
are not compatible.)Note that this fix is necessary only for the
maint-0.9
branches and the REANA 0.9 release series. Inmaster
we have switched to Ubuntu 24.04 LTS based environments and Python 3.12 and no pinning is necessary there.