Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new uiimage_requires_bundle Rule #5177

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielPeloton
Copy link

Adds a new rule to help ensure that use of UIImage(named:) includes a bundle, helpful for modularized codebases.
This was based on the very similar NSLocalizedStringRequireBundleRule

@@ -206,6 +206,7 @@ public let builtInRules: [Rule.Type] = [
UnavailableConditionRule.self,
UnavailableFunctionRule.self,
UnhandledThrowingTaskRule.self,
UIImageIncludesBundleRule.self,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this and the lines in GeneratedTests.swift to check the rule, but I'm sure there's a more appropriate way to get Sourcery involved here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sourcery

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! Please add a CHANGELOG entry to make people aware of the new rule.

static let description = RuleDescription(
identifier: "uiimage_requires_bundle",
name: "UIImage Requires Bundle",
description: "`UIImage(named:) must specify a bundle via the `in:` parameter",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "`UIImage(named:) must specify a bundle via the `in:` parameter",
description: "`UIImage(named:)` must specify a bundle via the `in:` parameter",

@@ -206,6 +206,7 @@ public let builtInRules: [Rule.Type] = [
UnavailableConditionRule.self,
UnavailableFunctionRule.self,
UnhandledThrowingTaskRule.self,
UIImageIncludesBundleRule.self,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sourcery

}
}

private extension TupleExprElementListSyntax {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy of the same extension in NSLocalizedStringRequireBundleRule. Please move it to SwiftSyntax+SwiftLint.swift to make it reusable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pushed that file beyond 400 lines! I tried working around this by moving any extensions on structures defined inside the generated SyntaxCollections (these three: AttributeListSyntax, ModifierListSyntax, and TupleExprElementListSyntax), but I get this error: testSwiftLintLints(): failed - File name should match a type or extension declared in the file (if any) This is on a file I called SwiftSyntaxCollections+SwiftLint.swift. How would you recommend getting around this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file_length rule has meanwhile been disabled in SwiftSyntax+SwiftLint.swift. You don't have to bother with that anymore. I'd rather like to have these extension in one place.

@SwiftLintBot
Copy link

882 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR introduced a violation in Brave: /ThirdParty/Static/Static/Tests/RowTests.swift:21:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AboutViewController.swift:50:32: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AboutViewController.swift:52:32: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:42:28: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:43:31: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:44:30: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:45:29: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:46:31: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:47:30: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:55:28: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:56:31: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:57:30: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:58:29: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:59:31: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppIcon.swift:60:30: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppTrackerImageCache.swift:100:25: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppTrackerImageCache.swift:97:35: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppTrackerImageCache.swift:98:35: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AppTrackerImageCache.swift:99:33: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AuthenticationViewController.swift:107:27: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AuthenticationViewController.swift:109:27: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillItemsEmptyView.swift:70:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillItemsLockedView.swift:25:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillLoginSettingsListViewController.swift:52:32: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillNoAuthAvailableView.swift:35:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillNoAuthAvailableView.swift:71:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarkFolderCell.swift:46:37: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:297:38: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:311:30: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:584:32: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:629:24: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FaviconViewModel.swift:24:28: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FaviconsHelper.swift:51:22: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FavoritesHomeViewSectionRenderer.swift:239:36: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FavoritesHomeViewSectionRenderer.swift:244:38: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FeedbackFormViewController.swift:104:29: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FeedbackFormViewController.swift:86:29: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FindInPageActivity.swift:36:16: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/ImageCacheDebugViewController.swift:111:41: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/JSAlertController.swift:24:45: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/MacWaitlistViewController.swift:111:57: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/MainViewController.swift:338:40: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/MenuButton.swift:93:35: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/OnboardingWidgetsDetailsViewController.swift:32:25: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/SaveBookmarkActivity.swift:50:30: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/SaveBookmarkActivity.swift:50:70: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/SettingsViewController.swift:491:52: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/SuggestionTableViewCell.swift:39:31: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/SuggestionTableViewCell.swift:43:35: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/SuggestionTableViewCell.swift:46:35: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabSwitcherViewController.swift:130:44: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabSwitcherViewController.swift:132:44: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabSwitcherViewController.swift:136:44: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabSwitcherViewController.swift:138:44: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:2221:37: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:2223:37: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:104:57: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:123:57: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:140:47: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:140:85: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:156:53: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:163:49: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:175:76: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:201:53: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:208:49: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:244:58: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:254:54: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:288:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:375:35: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:375:79: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:37:57: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:42:85: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:48:84: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:60:85: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:81:57: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:90:61: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewControllerBrowsingMenuExtension.swift:97:57: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewGridCell.swift:106:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewGridCell.swift:151:29: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewGridCell.swift:87:87: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewGridCell.swift:91:87: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewListCell.swift:70:29: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/WindowsWaitlistViewController.swift:155:57: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/FaviconsTests.swift:120:27: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/FaviconsTests.swift:135:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/FaviconsTests.swift:145:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /LocalPackages/SyncUI/Sources/SyncUI/Views/SyncSettingsView.swift:60:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in DuckDuckGo: /LocalPackages/SyncUI/Sources/SyncUI/Views/SyncSettingsView.swift:60:72: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/ComponentLibrary/BottomSheet/BottomSheetViewController.swift:55:25: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/ComponentLibrary/CollapsibleCardView.swift:61:24: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/ComponentLibrary/CollapsibleCardView.swift:63:24: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /BrowserKit/Sources/SiteImageView/ImageProcessing/ImageHandler.swift:122:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/AccessoryViewProvider.swift:72:27: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Experiments/Settings/Views/ExperimentsSettingsView.swift:14:25: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:20:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:22:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:24:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:26:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:28:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:30:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:32:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Autofill/CreditCard/Logic/CreditCardValidator.swift:34:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardTableViewCell.swift:113:33: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/EnhancedTrackingProtection/EnhancedTrackingProtectionVC.swift:443:27: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/EnhancedTrackingProtection/EnhancedTrackingProtectionVC.swift:68:25: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FindInPageBar.swift:106:30: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FindInPageBar.swift:91:33: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FindInPageBar.swift:98:29: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:101:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:108:20: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:257:60: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:265:60: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:40:27: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift:44:27: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift:276:31: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift:656:51: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift:752:33: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift:81:16: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift:85:16: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/TabTrayButtonExtensions.swift:14:25: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tabs/GroupedTabCell.swift:182:25: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Tabs/InactiveTabs/InactiveTabButton.swift:102:21: warning: UIImage Requires Bundle Violation: UIImage(named:) must specify a bundle via the in: parameter (uiimage_requires_bundle)
⚠️ Danger found 882 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 123.
17 Messages
📖 Linting Aerial with this PR took 1.12s vs 1.12s on main (0% slower)
📖 Linting Alamofire with this PR took 1.46s vs 1.46s on main (0% slower)
📖 Linting Brave with this PR took 8.41s vs 8.37s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.15s vs 4.12s on main (0% slower)
📖 Linting Firefox with this PR took 9.86s vs 9.8s on main (0% slower)
📖 Linting Kickstarter with this PR took 10.63s vs 10.52s on main (1% slower)
📖 Linting Moya with this PR took 0.6s vs 0.6s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.18s vs 3.17s on main (0% slower)
📖 Linting Nimble with this PR took 0.78s vs 0.77s on main (1% slower)
📖 Linting PocketCasts with this PR took 8.41s vs 8.37s on main (0% slower)
📖 Linting Quick with this PR took 0.38s vs 0.39s on main (2% faster)
📖 Linting Realm with this PR took 12.0s vs 11.88s on main (1% slower)
📖 Linting Sourcery with this PR took 2.41s vs 2.38s on main (1% slower)
📖 Linting Swift with this PR took 5.11s vs 5.07s on main (0% slower)
📖 Linting VLC with this PR took 1.42s vs 1.42s on main (0% slower)
📖 Linting Wire with this PR took 8.72s vs 8.66s on main (0% slower)
📖 Linting WordPress with this PR took 12.6s vs 12.47s on main (1% slower)

Here's an example of your CHANGELOG entry:

* Add new `uiimage_requires_bundle` Rule.  
  [danielPeloton](https://github.com/danielPeloton)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants