Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tooltips in :numref: #71

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Support tooltips in :numref: #71

merged 3 commits into from
Apr 24, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 20, 2020

Closes #70

@humitos humitos requested a review from a team April 20, 2020 15:57
@humitos humitos mentioned this pull request Apr 20, 2020
Closed
ericholscher
ericholscher approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This should probably be added to the docs as an available option for hoverxref_roles

@humitos humitos merged commit 3558a67 into master Apr 24, 2020
@humitos humitos deleted the humitos/support-numref branch April 24, 2020 14:55
@kerimoyle
Copy link

Thanks very much :)

@kerimoyle
Copy link

Hi again - Do you know when you're likely to have a new release version (in particular, one that includes this update)? I'd like to be able to pin it into our project nicely :)

@humitos
Copy link
Member Author

humitos commented Apr 28, 2020

@kerimoyle I don't have an ETA. I wanted to get #68 merged as well, but that requires some extra work in the server as well that I need to finish testing. Hopefully this happens next week :)

@kerimoyle
Copy link

Hey there @humitos! Just wanted to check in about getting a release version containing #71 ? Hope you're well ... thanks :)

@kerimoyle kerimoyle mentioned this pull request May 24, 2020
Merged
@humitos
Copy link
Member Author

humitos commented May 25, 2020

Thanks for pinging back. It's on my TODO list. Hopefully, I can get into this today or this week.

@humitos
Copy link
Member Author

humitos commented May 26, 2020

@kerimoyle I just uploaded 0.4b1 to PyPI. Please, let me know if everything works as you expected! 😄

@kerimoyle
Copy link

Yes! Hurrah! All working nicely. Thanks so much 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anyway to support tooltips for internal references created by numref?
3 participants
@humitos @kerimoyle @ericholscher