API: separate querysets from API V2 and V3 #11586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Sep 5, 2024
Agreed! 👍🏼 |
humitos
reviewed
Sep 9, 2024
Comment on lines
+122
to
+123
| def api_v2(self, *args, **kwargs): | ||
| return self.api(*args, **kwargs) |
There was a problem hiding this comment.
It would be good to have a comment on these methods that explains the differences between .api and .api_v2. Even reading the current context from the issues, it's still hard to have everything in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to override just the v2 querysets on .com, since we want to share the same logic as .org for v3.
ref readthedocs/ext-theme#154