Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per ad per day advertiser table/export #921

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

davidfischer
Copy link
Collaborator

Creates a metabase view for advertisers to view a per ad per day breakdown. It isn't visualized but just a table that they can download and export.

Screenshot

Screenshot from 2024-10-02 12-43-26

Screenshot from 2024-10-02 12-45-36

@davidfischer davidfischer requested a review from a team as a code owner October 2, 2024 19:46
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 💯

@@ -44,6 +44,11 @@ <h2 class="col-md-8">{% trans 'Total results for all ads across all flights' %}<

{% if export_url %}
<aside class="mb-3 col-md-4 text-right">
<a href="{% url 'advertiser_per_ad_report' advertiser.slug %}" class="btn btn-sm btn-outline-secondary" role="button" aria-pressed="true">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder about putting it in the sidebar under Reports as well? Maybe after we test it a bit more?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

{% block explainer %}
<section class="mb-5">
<h3>{% trans 'About this report' %}</h3>
<p>{% trans 'This report shows a table of data with one entry for each ad for every day that ad is shown. The data can be exported to CSV/Excel for further analysis with the icon at the bottom right.' %}</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to make the export info a bit more prominent? Perhaps bolded or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@davidfischer davidfischer merged commit 5032bd3 into main Oct 10, 2024
1 check passed
@davidfischer davidfischer deleted the davidfischer/per-ad-per-day-export branch October 10, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants