File Tree Diff: initial implementation #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new addon to show all the filenames and URLs that were added, deleted or modified in the current PR compared to the LATEST version. Closes #409
Usage example (together with docdiff)
|
|
OOOF I WANT THIS |
ericholscher
approved these changes
Nov 7, 2024
|
|
||
| showDiff() { | ||
| // const outdated = objectPath.get(this.config, "addons.filetreediff.oudated", false); | ||
| const diffdata = objectPath.get(this.config, "addons.filetreediff.diff"); |
There was a problem hiding this comment.
I think we probably want camelcase if we're being good JS style:
Suggested change
| const diffdata = objectPath.get(this.config, "addons.filetreediff.diff"); | |
| const diffData = objectPath.get(this.config, "addons.filetreediff.diff"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new addon to show all the filenames and URLs that were added, deleted or modified in the current PR compared to the LATEST version.
I'm rendering this data in a new notification decoupled from the existing one on purpose. I don't want to entangle the code of these two different addons for now, in particular while we are under development/testing. I also see that in the future they may have different UI elements, or the data will be integrated in a more bigger UI element (eg. toolbar) or similar.
We can discuss more how this addon will grow and where is a good place to add this data and make that work in a following PR. For now, I want something that we can start testing internally in our own projects.
Examples
Closes #409
Requires readthedocs/readthedocs.org#11749