Android / Gradle updates (current working build) #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…28, build tools to 28.0.3, Gradle 4.10.2, max processors / thread 6 (native NDK compiler), see readium/readium-sdk#317
danielweck
added a commit
to readium/SDKLauncher-Android
that referenced
this pull request
Nov 19, 2018
…28, build tools to 28.0.3, Gradle 4.10.2, see readium/readium-sdk#317 and readium/readium-lcp-client#49
|
TODO: the references to the bintray repository should probably be updated in order to reflect the latest available versions, for example: https://bintray.com/android/android-tools/com.android.tools.build.gradle/view vs. https://mvnrepository.com/artifact/com.android.tools.build/gradle?repo=google ...and: https://bintray.com/android/android-tools/com.android.tools.build.gradle-experimental/view vs. https://mvnrepository.com/artifact/com.android.tools.build/gradle-experimental?repo=google Also see: https://developer.android.com/studio/releases/gradle-plugin |
…only, x86-only, or ARM+x86
…o lib which excludes ReadiumSDK / content module + filter)
…sts existing user keys available in the secret vault (as opposed to the codepath that uses the passphrase to unlock the license), see #51
… otherwise fatal fail uncaught exception!
|
This PR also addresses the general issue of verifying that UTF8 characters are valid before comparing them (LCP keycheck is the prime example!) |
…LCP license is undefined (absent property). The bug was due to the RapidJSON move semantics not copying the allocator in Value objects (only in Document objects) when return a function value. Works fine in function parameters, due to the stacking memory context. Without this fix, the GetType() function returns 16 (or some other weird value) instead of zero for kNullType enum, and isNull() returns false due to internal mismatch in the mask value. https://github.com/Tencent/rapidjson/blob/master/include/rapidjson/document.h#L1954 https://rapidjson.org/md_doc_tutorial.html#TemporaryValues Tencent/rapidjson#387 (comment)
…ly padding (W3C with zeros or PKCS), as opposed to partial padding. In other words, zero-padding actually never occurs (even for cypher data that is exactly a multiple of block size), instead a full block is allocated and suffixed to the cypher stream. The general case of partial padding between 1-15 bytes was working fine, this fix adds support for the edge case of zero-padding (full 16-bytes padding block)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded API 26 to 28, build tools to 28.0.3, Gradle 5.4.1, max processors / thread 6 (native NDK compiler). NDK is version
16.1.4479499:https://github.com/android/ndk/wiki/Unsupported-Downloads#r16b
https://developer.android.com/ndk/downloads/older_releases#ndk-16b-downloads
Pre-requisite (must read comments, notably the "Build output" section):
readium/readium-sdk#317
platform/android/local.properties(not checked into Git, must be created by developers)
Build output
When invoking
gradlew assembleDebug, a successful build output libs into theplatform/android/lib/libs/folder (armeabi-v7aandx86subfolders), but there are also build artifacts in theplatform/android/lib/build/outputs/aarfolder (note that launching the SDKLauncher-Android app from AndroidStudio also invokes the LCP Gradle build script):Finally, there is also a
platform/android/dist/folder generated by the production build script:https://github.com/readium/readium-lcp-client/blob/feature/latest-working-build-config/platform/android/lib/build.gradle#L174