Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MASTER] Add x86 and x64 builders/testers for -DSAFE_TESTS_ONLY=1 #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ColinFinck
Copy link
Member

@ColinFinck ColinFinck commented Aug 13, 2023

As requested by @tkreuzer, here comes an extra tester for a rostests build with -DSAFE_TESTS_ONLY=1.
This allows @tkreuzer to implement a list of safe tests in the main repo and only run these (without crash recovery).

Next to the testers, I needed to add an extra builder for x86 and x64.
This is necessary, because:

  • The x64 builder is a Windows MSVC builder, but the x64 tester is a Linux server with KVM. This is why we can't have a combined builder/tester for x64 (and I did it the same for x86 for consistency).
  • We can't just add another step to the existing x86/x64 builders, because we need to transfer the bootcdregtest to the tester after build. They are distinguished via their suffix, and there can only be one suffix per builder.

I took the opportunity to clean up our BuildBot master.cfg, deduplicate lots of copy-pastes, and remove commented out and long obsoleted configs.
Therefore, this PR is best to be reviewed commit by commit.

@ColinFinck
Copy link
Member Author

Copy link

@tkreuzer tkreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really judge the code, but I like to have this thing. So approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants