fix: update SidebarNav component style

[victorlunam]

considering that the grid-template for the “lg” breakpoint is “grid-cols-sidebar-content”.

react.dev/src/components/Layout/Page.tsx

Lines 146 to 150 in b12743c

	<div
	className={cn(
	hasColumns &&
	'grid grid-cols-only-content lg:grid-cols-sidebar-content 2xl:grid-cols-sidebar-content-toc'
	)}>

react.dev/tailwind.config.js

Lines 155 to 159 in b12743c

	gridTemplateColumns: {
	'only-content': 'auto',
	'sidebar-content': '20rem auto',
	'sidebar-content-toc': '20rem auto 20rem',
	},

and the fixed width of the SidebarNav in:

react.dev/src/components/Layout/SidebarNav/SidebarNav.tsx

Line 37 in b12743c

className="overflow-y-scroll no-bg-scrollbar lg:w-[342px] grow bg-wash dark:bg-wash-dark"

---

I think the “20rem” width might not be enough, considering the fixed width of the SidebarNav.

I think we could consider that the width should be defined in the grid-template.

Issue solved

• [Bug]: The sidebar overlaps the content #6941

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
19-react-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2024 3:34pm
react-dev	✅ Ready (Inspect)	Visit Preview		Jun 11, 2024 3:34pm

[facebook-github-bot]

Hi @victorlunam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[github-actions]

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
/404	80.78 KB (🟢 -10 B)	184.92 KB
/500	80.77 KB (🟢 -10 B)	184.92 KB
/[[...markdownPath]]	82.62 KB (🟢 -10 B)	186.77 KB
/errors	80.99 KB (🟢 -10 B)	185.13 KB
/errors/[errorCode]	80.97 KB (🟢 -10 B)	185.11 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!