-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0 #1
base: master
Are you sure you want to change the base?
Version 1.0 #1
Conversation
Branch is this one: https://github.com/reactive-streams/reactive-streams-scalajs/tree/version-1 |
* Red Hat Inc., currently represented by Tim Fox (@purplefox) and Norman Maurer (@normanmaurer) | ||
* Twitter Inc., currently represented by Marius Eriksen (@mariusaeriksen) | ||
* Typesafe Inc., currently represented by Viktor Klang (@viktorklang) and Roland Kuhn (@rkuhn) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is somewhat outdated now; shall I write up the changes needed or we leave as is? cc @viktorklang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's pretty outdated, but I think it needs to be updated separately. I'll open an Issue to discuss that.
As far as for an initial import LGTM. |
@@ -1,116 +1,8 @@ | |||
CC0 1.0 Universal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why this file was modified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the LICENSE
from the JVM project, because I saw a difference between LICENSE
and COPYING
and I also brought it COPYING
. Not sure why, thought it makes sense to have it identical to the JVM project, but I'm not a lawyer.
I can revert this change if you want, no problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes total sense to have it be identical to the JVM project. I only wanted to know the rationale :)
I'm not entirely sure we need a ScalaJS on reactive-streams org but I don't explicitly mind neither. So I guess I'm not really qualified to discuss about it 👍 |
@smaldini I guess it needs to be under the same organisation as the other reactive streams artifacts or otherwise it wouldn't be substitutable between compiling for jvm vs compiling for js. I think that's a good enough reason for a separate project but under the same umbrella, of course as long as it doesn't deviate from the RS APIs, spec and TCK. Personally I'd love to see more action over here as well: https://github.com/reactive-streams/reactive-streams-js :) |
I understand, IMO the only point that could save us from repeat is a plain JS TCK. At least something to test all JS impls given the natively useless nature of types in JS (and for RS in general I'd argue its about the behavior, the types don't bring much). Would that work for ScalaJS as well ? |
That said somehow, seeing engineering practices in JS is not something I'm fighting off quite the contrary, I live in a perpetual JS dev trauma ever since I touched it. |
@smaldini I think scalajs could use the -jvm TCK for the server side and if needed, the -js TCK (when available) to run on V8 etc. (I did JavaScript before there were frameworks/libs) #jshipster :) |
Right now JUnit support is built in in Scala.js and ScalaCheck support even asynchronous testing, Hope this could revamp the discussion and we can end up with a solution! |
Hi guys. What would be needed to move this project forward. A TCK? |
@alexandru A TCK would most definitely be helpful. :) |
The version 1.0 for the Scala.js API.
built.sbt
as best as I could, should be ready for publishing :-) but please check that I haven't missed anythingPublisher.subscribe
does use-site variance because this interface is meant for cross-compiled projects and so the translation has to be exact