-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access to client's localStorage and sessionStorage #1091
Access to client's localStorage and sessionStorage #1091
Conversation
Hello! Just wondering. Why hasn't this push been merged since July? I'm building a frontend service using ReactPy and it's a non-starter to not have access to local storage. |
I am stuck, there is no session_storage or local_storage or cookie like system to work with, In the middle of my dream project |
Even Reflex, Flet having options for LocalStorage, SessionStorage |
Please consider this pull request; it addresses a crucial core feature that we urgently need. |
The PR seems to be ok and implements an extremely important feature. Mainly for those who want to put the project into production using Reactpy. |
@williamneto Hey William. We've been trying to limit features in We like the concept of these hooks, but we were wondering if you could fork it into a separate package? |
when will I expect the LocalStorage option? |
There is no way to use this option ? |
After discussion, we decided we don't want to create ~20 hooks for every single web application API directly within ReactPy core. #1075 ReactJS philosophy is to focus on primitives within the core library. So following that philosophy, we've landed on a generic The Hopefully we'll be able to get that pushed through within the next 30-60 days. |
As sugested by @Archmonger , the implementation i proposed for local storage is in my fork williamneto/reactpy. Just merged the latest version of the original into the fork. There is a usage sample in react/samples |
@williamneto How to build the project? |
@williamneto I wasn't referring to forking the whole project. It would be better make a minimal package on PyPI named something like That would require PRing ReactPy core to add some third-party extensibility to
Also, instead of creating unique properties within the |
@Archmonger Better you can create on reactive-python account itself, so new bees will find out easily, and plz solve the issue as soon as possible bcz most people waiting for this option |
So @Archmonger , i started studing arround this reactpy-client-storage approach. Realy makes more sense. But i ended up in the same question presented in #1084 : the necessity to extend the client-server comunications, as by now it only supports LayoutEvent and LayoutUpdate messages. After #1084 being merged it will be possible to think about extensions like reactpy-client-storage, reactpy-client-services, etc |
But #1084 is Still in the draft section since July 2023 |
@kumaraguru1735 The PR author, Ryan, needed to step away from OSS for a few months. He's back since mid-December and progress will be made on that PR soon. |
For people that need immediate access to these hooks, We'll work with him to create a separate package for these hooks once the |
When Will I expect it ? |
Issues
Discussed in #1083 and #1075
Solution
The methods use_local_storage and use_session_storage have been implemented to provide access to these two client storage instances.
Checklist
changelog.rst
has been updated with any significant changes.