-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactPy ASGI App and Middleware #1110
Comments
@rmorshea I can also develop a WSGI variant of this. However, it will only work with WSGI webservers that have official websocket support: The design of this would be largely based on |
If we could take a similar approach to simplifying the flask/tornado backends that would be good too. If not, doesn't seem necessary. Regardless, probably should be done in a separate PR. |
WSGI middleware would grant us compatibility with the following frameworks: https://wsgi.readthedocs.io/en/latest/frameworks.html Unfortunately tornado uses its own custom API, so we would either need to drop support for tornado or keep using |
I'm realizing that tornado support should almost certainly be spun off into its own package, similar to ReactPy-Django. |
Current Situation
Currently we perform ASGI routing via backend-specific APIs. However, it is much easier to gain broad compatibility via ASGI middleware. Additionally, we should have a "standalone" mode where ReactPy can run in a production configuration without any backend.
I originally pitched this concept a long time ago during our development of our
configure()
function.Proposed Actions
Create a ReactPy ASGI application that can also function as middleware.
Interface Design
Implementation Draft
The text was updated successfully, but these errors were encountered: