Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanic warning when running via docs instructions #1154

Closed
Archmonger opened this issue Oct 10, 2023 Discussed in #1150 · 1 comment
Closed

Sanic warning when running via docs instructions #1154

Archmonger opened this issue Oct 10, 2023 Discussed in #1150 · 1 comment

Comments

@Archmonger
Copy link
Contributor

Discussed in #1150

Originally posted by JamesHutchison October 6, 2023
The docs currently recommend running via Sanic directly.

https://reactpy.dev/docs/guides/getting-started/running-reactpy.html#running-with-sanic

However, if you do, you get this warning:

No scope. Sanic may not be running with an ASGI server

It seems like if users should be using the built-in Sanic server then this warning should be remove, as it is emitted by ReactPy here:

https://github.com/reactive-python/reactpy/blob/main/src/py/reactpy/reactpy/backend/sanic.py#L167

If users should be using ASGI to serve Sanic, then instructions on how to do that should be provided.

@Archmonger
Copy link
Contributor Author

Closing in favor of #1110

@Archmonger Archmonger closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant