-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): Bump version for Next storage #1028
Conversation
@@ -47,14 +47,19 @@ buildscript { | |||
? rootProject.ext['kotlinVersion'] | |||
: rootProject.hasProperty('AsyncStorage_kotlinVersion') | |||
? rootProject.properties['AsyncStorage_kotlinVersion'] | |||
: '1.8.10' | |||
: '1.9.20' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause issues when react-native
is still on 1.8? And what about older versions?
In react-native-test-app
, we keep a list of compatible versions: https://github.com/microsoft/react-native-test-app/blob/e43b6a622bffaa76ce28e1ed1c4f036db6611342/android/dependencies.gradle#L6
Should we be doing the same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kotlin is being kept forward binary compatible, so It should be fine with older versions. Gradle will select latest kotlin version and evict the rest.
I do like your suggestion tho, I could add a map of supported KSP versions, so we can decide on it based on Kt version used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of the supported KSP versions map will be particularly valuable for legacy projects, providing a clear understanding of compatibility.
cd6d034
to
5a4c5ea
Compare
@tido64 Moved the config to separate file, for easier management. I left an option to still be able to override KSP version, in case Kotlin v2 and supporting KSP releases, before we add support for it. |
@tido64 CI is failing due to
I had same issue locally, where |
Seems like we're missing the latest version: microsoft/react-native-test-app#1701 I've also updated the logic to not return Update: Can you try bumping to 2.5.33? |
5a4c5ea
to
9d87a32
Compare
Bumped, let's give it a go 🤞 |
Looks like we need to bump Robolectric:
Latest version should support up to 34. |
|
"android/build.gradle", | ||
"android/src", | ||
"android/testresults.gradle", | ||
"android/", | ||
"!android/.gradle", | ||
"!android/build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some weird reason, the src
dir was not added, so had to add all and exclude build files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be related to the rewrite of the glob implementation in npm 9. We've hit issues with it as well: npm/npm-packlist#152
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not cool!
9d92442
to
ab7fe04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@tido64 added a log to it. I'm going to release this as minor version update, due to libraries bump |
🎉 This PR is included in version 1.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
kapt
in favor ofksp
, which version can be set via gradle property