-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Win] Enhance OptSpecialChars dead keys processing #732
base: master
Are you sure you want to change the base?
Conversation
For Windows/AHK: Adds more accurate and intuitive behavior to the process of using dead keys, to match macOS more closely, and fixes some of the Switch/Case lines that weren't working as expected (Escape, Space were not actually activating). Dead keys sequences will now place the pending diacritic accent character (e.g., umlaut [ ¨ ]) in a highlight, then either replace it with the full accented character (e.g., [ Ü ]) if there is a match, or deselect the diacritic character and exit the dead keys sequence, leaving the diacritic character visible. Any input other than Escape or Space or a matching letter will be passed through. This is a very close match for how dead keys work in macOS. Also enabled the ability to interrupt a dead key sequence by triggering another dead key sequence, which like many other keys will just leave the original diacritic character visible and insert the new one in a highlight as the start of the new sequence. This behaves like it does on a Mac when you change your mind in the middle and do a different dead key. Previous PR by this name had some unforeseen issues with non-character-generating input editing keys like arrows, Backspace, and Delete, which were being ignored/disabled by the AHK `Input` command. And the uppercase accented characters were not working properly. All such issues are fixed here and thoroughly tested. 🤞🏽 😮💨 🤞🏽
Added support for exiting dead keys with appropriate actions for the arrow keys, mimicking what happens in macOS as closely as possible. |
@RedBearAK, do you know if these modifications would also work for this configuration? I'm having a hard time with a Magic Keyboard here on KDE ^^
|
There are several different aspects of the answer to this question.
If you want to talk more about this, feel free to open an issue thread on the Toshy repo. |
@RedBearAK, thanks a lot for your quick and informative reply :) I'm going to check your repo here o/ Uhuul |
@rbreaves
For Windows/AHK:
Adds more accurate and intuitive behavior to the process of using dead keys, to match macOS more closely, and fixes some of the Switch/Case lines that weren't working as expected (Escape, Space were not actually activating).
Dead keys sequences will now place the pending diacritic accent character (e.g., umlaut [ ¨ ]) in a highlight, then either replace it with the full accented character (e.g., [ Ü ]) if there is a match, or deselect the diacritic character and exit the dead keys sequence, leaving the diacritic character visible. Any input other than Escape or Space or a matching letter will be passed through. This is a very close match for how dead keys work in macOS.
Also enabled the ability to interrupt a dead key sequence by triggering another dead key sequence, which like many other keys will just leave the original diacritic character visible and insert the new one in a highlight as the start of the new sequence. This behaves like it does on a Mac when you change your mind in the middle and do a different dead key.
[EDIT: Added Ctrl keys to break the dead keys sequence when switching away to another app. This also matches the macOS behavior when you task switch before completing the dead keys sequence.]
Previous PR by this name had some unforeseen issues with non-character-generating input editing keys like arrows, Backspace, and Delete, which were being ignored/disabled by the AHK
Input
command. And the uppercase accented characters were not working properly. All such issues are fixed here and thoroughly tested.🤞🏽 😮💨 🤞🏽