fix(scrollTo): reset actualAnchor on error

rbalet · Apr 24, 2024 · 6058354 · 6058354
1 parent ea98dc0
commit 6058354
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-href",
-  "version": "17.3.0",
+  "version": "17.4.0",
   "license": "MIT",
   "author": "Raphael Balet",
   "maintainers": [

diff --git a/projects/ngx-href/package.json b/projects/ngx-href/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-href",
-  "version": "17.3.0",
+  "version": "17.4.0",
   "license": "MIT",
   "author": {
     "name": "Raphaël Balet",

diff --git a/projects/ngx-href/src/lib/href.service.ts b/projects/ngx-href/src/lib/href.service.ts
@@ -44,10 +44,12 @@ export class NgxHrefService {
   scrollTo(anchor?: string, counter = 0) {
     if (
       !anchor ||
-      counter >= 10 || // Counter over, this element doesn't exist or the page is too slow
-      (anchor === this._actualAnchor && counter === 0) // Multiple click on the same url
-    )
+      counter >= 10 // Counter over, this element doesn't exist or the page is too slow
+    ) {
+      this._actualAnchor = undefined
       return
+    }
+    if (anchor === this._actualAnchor && counter === 0) return // Multiple click on the same url
 
     if (counter === 0) {
       this.setAnchor(anchor)