Add popup support #70
Conversation
|
Any reason to not merge this? Exactly what I was looking for! |
|
Greatly needed! |
|
If this feature is intended to be merged in the near future, an update would be greatly appreciated. |
| type: [Number, Object, Array] as PropType<Offset>, | ||
| required: false, | ||
| }, | ||
| className: { |
There was a problem hiding this comment.
Provide a default value for not required props.
| required: false | ||
| } | ||
| }, | ||
| async setup(props, { slots, emit }) { |
There was a problem hiding this comment.
Is the async needed? There is no await keyword.
There was a problem hiding this comment.
This should be flagged with linting no?
There was a problem hiding this comment.
The async is not needed here. I fixed it on my fork: https://github.com/indoorequal/vue-maplibre-gl
|
Waiting for this too! |
|
I started a fork with some documentation, examples and popup support: https://github.com/indoorequal/vue-maplibre-gl. |
|
@razorness what's the status of this PR and this repo in general? If this repo no longer maintained I can replace the reference in awesome-maplibre to the maintained fork. |
|
I guess the answer is that it is no longer maintained... I'll push forward the above linked PR. |
This add support for Popup: https://maplibre.org/maplibre-gl-js/docs/API/classes/maplibregl.Popup/
Adding html content or text is supported as well as the others attributes.