media: i2c: ov9282: Correct the exposure offset #6522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datasheet lists that "Maximum exposure time is frame
length -25 row periods, where frame length is set by
registers {0x380E, 0x380F}".
However this driver had OV9282_EXPOSURE_OFFSET set to 12
which allowed that restriction to be violated, and would
result in very under-exposed images.
Correct the offset.
Fixes: 14ea315 ("media: i2c: Add ov9282 camera sensor driver")
Signed-off-by: Dave Stevenson <[email protected]>
|
Reported https://forums.raspberrypi.com/viewtopic.php?p=2274970#p2274970 |
|
Sent upstream and has a R-b |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 10, 2024
kernel: Revert "PCI: Warn if no host bridge NUMA node info" See: raspberrypi/linux#6531 kernel: drm/v3d: Enable Performance Counters before clearing them See: raspberrypi/linux#6514 kernel: configs: Enable Intel Wireless (PCI) drivers See: raspberrypi/linux#6526 kernel: media: i2c: ov9282: Correct the exposure offset See: raspberrypi/linux#6522 kernel: waveshare panel driver update See: raspberrypi/linux#6499 kernel: dtoverlays: Add Arducam override for ov9281 See: raspberrypi/linux#6506 kernel: nvme-pci: Disable Host Memory Buffer usage See: raspberrypi/linux#6510 kernel: Allow setting I²C clock frequency via i2c_arm_baudrate dtparam when using pimidi overlay See: raspberrypi/linux#6513
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Dec 10, 2024
kernel: Revert "PCI: Warn if no host bridge NUMA node info" See: raspberrypi/linux#6531 kernel: drm/v3d: Enable Performance Counters before clearing them See: raspberrypi/linux#6514 kernel: configs: Enable Intel Wireless (PCI) drivers See: raspberrypi/linux#6526 kernel: media: i2c: ov9282: Correct the exposure offset See: raspberrypi/linux#6522 kernel: waveshare panel driver update See: raspberrypi/linux#6499 kernel: dtoverlays: Add Arducam override for ov9281 See: raspberrypi/linux#6506 kernel: nvme-pci: Disable Host Memory Buffer usage See: raspberrypi/linux#6510 kernel: Allow setting I²C clock frequency via i2c_arm_baudrate dtparam when using pimidi overlay See: raspberrypi/linux#6513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datasheet lists that "Maximum exposure time is frame length -25 row periods, where frame length is set by registers {0x380E, 0x380F}".
However this driver had OV9282_EXPOSURE_OFFSET set to 12 which allowed that restriction to be violated, and would result in very under-exposed images.
Correct the offset.
Fixes: 14ea315 ("media: i2c: Add ov9282 camera sensor driver")