rtc: rv3028: Fix backup-switchover-mode crash

Commit "rtc: rv3028: Mirror BSM and TCE/TCR to EEPROM" was a forward-port from rpi-5.9.y, and between then and rpi-5.15.y the rv3028_eeprom_read function was changed from requiring a regmap pointer to a pointer to the rv3028_data structure. However, because the declaration specifies a void * pointer, the compiler issues no warning and the added call to rv3028_eeprom_read leads to an exception when backup-switchover-mode is used. See: #2912 Signed-off-by: Phil Elwell <[email protected]>
raspberrypi · Jan 9, 2023 · cd8d5fb · cd8d5fb
1 parent d8ca89e
commit cd8d5fb
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
@@ -963,8 +963,7 @@ static int rv3028_probe(struct i2c_client *client)
 	}
 
 	if (backup_mask) {
-		ret = rv3028_eeprom_read((void *)(rv3028->regmap),
-					 RV3028_BACKUP,
+		ret = rv3028_eeprom_read((void *)rv3028, RV3028_BACKUP,
 					 (void *)&backup, 1);
 		/* Write register and EEPROM if needed */
 		if (!ret && (backup & backup_mask) != backup_bits) {