Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera sw: Update build instruction for the new meson options #3633

Merged
merged 5 commits into from
May 17, 2024

Conversation

naushir
Copy link
Contributor

@naushir naushir commented May 14, 2024

The options have changed from boolean choices to meson feature types.

The options have changed from boolean choices to meson feature types.
@naushir
Copy link
Contributor Author

naushir commented May 14, 2024

This will need merging once we push raspberrypi/rpicam-apps#676 to rpicam-apps.

Copy link
Collaborator

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made a couple of minor changes to clean things up. Otherwise this looks solid, let me know when the update rolls out in Raspberry Pi OS and apt.

@naushir
Copy link
Contributor Author

naushir commented May 17, 2024

raspberrypi/rpicam-apps#676 has now been merged, so feel free to merge this one in as well.

@lurch
Copy link
Contributor

lurch commented May 17, 2024

@naushir It looks like that PR also adds a --post-process-libs option to rpicam-apps? Does that need to be added to the camera apps documentation in this repo, or is it purely there for test purposes only?

@naushir
Copy link
Contributor Author

naushir commented May 17, 2024

I'd leave it out for now. It is only used for our regression testing.

@naushir naushir marked this pull request as ready for review May 17, 2024 09:36
@nathan-contino nathan-contino merged commit a0bed69 into raspberrypi:develop May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants