Fix codespell behavior. #1769
Merged
Fix codespell behavior. #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
non-breaking
msarahan
approved these changes
Dec 17, 2024
| # ignore short words, and typename parameters like OffsetT | ||
| ignore-regex = "\\b(.{1,4}|[A-Z]\\w*T)\\b" | ||
| ignore-words-list = "inout,thirdparty" | ||
| ignore-words-list = "thirdparty,couldn" |
There was a problem hiding this comment.
I understand the other stuff, but what's going on here? I'm approving regardless.
There was a problem hiding this comment.
There's a bug in codespell that incorrectly marks couldn't as an invalid word. Several projects are working around this. I tried to report it here on an issue I thought was relevant, but it was marked off-topic by the maintainer. codespell-project/codespell#2786 (comment)
|
@msarahan Telemetry is failing on this PR. https://github.com/rapidsai/rmm/actions/runs/12363154195/job/34504792423?pr=1769 |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, I added support for
codespellin CCCL (NVIDIA/cccl#3168). @shwina noticed some issues in my PR that were fixed in NVIDIA/cccl#3182. This PR ports similar fixes to RMM, to makecodespellwork better when run both inside and outside ofpre-commit.Checklist