Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated factory functions from resource adaptors. #1767

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Remove deprecated factory functions from resource adaptors. #1767

merged 1 commit into from
Dec 17, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 14, 2024

Description

Closes #1616.

This removes factory functions for resource adaptors that were previously deprecated in RMM 24.10, in PR #1626.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 14, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice bdice self-assigned this Dec 14, 2024
@github-actions github-actions bot added the cpp Pertains to C++ code label Dec 14, 2024
@bdice bdice added feature request New feature or request breaking Breaking change and removed cpp Pertains to C++ code labels Dec 14, 2024
@bdice bdice marked this pull request as ready for review December 14, 2024 07:07
@bdice bdice requested a review from a team as a code owner December 14, 2024 07:07
@bdice bdice requested review from wence- and jrhemstad December 14, 2024 07:07
@bdice
Copy link
Contributor Author

bdice commented Dec 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit 65858a9 into rapidsai:branch-25.02 Dec 17, 2024
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@harrism harrism harrism approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees

@bdice bdice

Labels
breaking Breaking change feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove factory functions from resource adaptors
3 participants
@bdice @harrism @wence-