Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cuda11.8 nvcc dependency #1542

Merged

Conversation

trxcllnt
Copy link
Contributor

cuda-nvcc is the CUDA 12 package name but was being included in the CUDA 11 dependencies, making the conda solve impossible. This PR uses the same nvcc matrix as defined in the build dependencies list.

@trxcllnt trxcllnt added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 23, 2024
@trxcllnt trxcllnt requested a review from a team as a code owner April 23, 2024 21:21
Copy link

copy-pr-bot bot commented Apr 23, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the conda label Apr 23, 2024
@trxcllnt
Copy link
Contributor Author

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Apr 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit c74dda2 into rapidsai:branch-24.06 Apr 30, 2024
52 checks passed
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Jun 11, 2024
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jun 12, 2024
This fixes the matrix for `test_python` to allow for CUDA 11.4. Fixes a testing regression from #1542.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1579
copy-pr-bot bot pushed a commit that referenced this pull request Jun 17, 2024
This fixes the matrix for `test_python` to allow for CUDA 11.4. Fixes a testing regression from #1542.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants