-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --rm and --name to devcontainer run args #1539
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-24.06
from
trxcllnt:fea/devcontainer-run-args
May 9, 2024
Merged
add --rm and --name to devcontainer run args #1539
rapids-bot
merged 6 commits into
rapidsai:branch-24.06
from
trxcllnt:fea/devcontainer-run-args
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trxcllnt
commented
Apr 19, 2024
- Remove the devcontainer when the VSCode window closes
- Adds a descriptive name to the running container:
trxcllnt
added
3 - Ready for review
Ready for review by team
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Apr 19, 2024
harrism
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the local user name to the container name in the RAPIDS combined devcontainers too, if you haven't already?
@harrism done in rapidsai/devcontainers#276 |
raydouglass
reviewed
May 7, 2024
raydouglass
approved these changes
May 7, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.