Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --rm and --name to devcontainer run args #1539

Merged

Conversation

trxcllnt
Copy link
Contributor

  • Remove the devcontainer when the VSCode window closes
  • Adds a descriptive name to the running container:
    $ docker ps -a
    CONTAINER ID   IMAGE        ...  NAMES
    0dbb364fe544   vsc-rmm-...  ...  rapids-rmm-24.06-cuda12.2-conda
    
    $ docker rm -f rapids-rmm-24.06-cuda12.2-conda

@trxcllnt trxcllnt added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 19, 2024
@trxcllnt trxcllnt requested a review from a team as a code owner April 22, 2024 17:18
@github-actions github-actions bot added the ci label Apr 22, 2024
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the local user name to the container name in the RAPIDS combined devcontainers too, if you haven't already?

@trxcllnt
Copy link
Contributor Author

@harrism done in rapidsai/devcontainers#276

@harrism harrism removed the 3 - Ready for review Ready for review by team label May 9, 2024
@harrism
Copy link
Member

harrism commented May 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit f11c8ca into rapidsai:branch-24.06 May 9, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants