Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate unified Python/C++ docs #1324
Generate unified Python/C++ docs #1324
Changes from all commits
4221d9b
b55374b
9f511da
01cf111
dc7580d
b4aba22
d8a4688
fb8ff88
34eaea5
59deec7
8a42763
6ec93b4
229a37f
1c77fa7
851661c
d08a2cd
89ce300
3cc30f4
6fdf76f
ead9947
4200358
9e81c73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work to just leave off the
{.cpp}
? By default, Doxygen uses the language of the file the@code
is found in. Will that work for the unified case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately doxygen-generated XML does not correctly identify
hpp
files as C++ files. It does work forcpp
files, but since rmm's files are all headers I needed to specify this. I do wonder if updating to a newer version of doxygen would improve the situation, and I may test that. I think #1317 needs merging before an y PR to update doxygen, so if the test is promising I'll sequence that work appropriately.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try modifying the Doxyfile EXTENSION_MAPPING setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't seem to work, but I'm not sure why. Oddly, specifying
@code{.hpp}
works (whether or not hpp is added to theEXTENSION_MAPPING
), but the default inference of just@code
doesn't.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows up in the navigation bar (they call these "breadcrumbs").
I would prefer to do something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree -- never liked the "Welcome to" prefix on practically every Python package's docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This heading makes the breadcrumbs deeply nested. The navigation is awkward as a result.
Can we eliminate this level of the hierarchy entirely, so that it's something more like
Home / rmm C++ / API Reference / Memory Resources
? See if you can fuse this page'stoctree
intopython/docs/cpp.rst
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, this makes for an awkward breadcrumb.