Skip to content

Commit

Permalink
gate telemetry dispatch calls on TELEMETRY_ENABLED env var (#1752)
Browse files Browse the repository at this point in the history
Because of the switch away from certificates/mTLS, we are having to rework a few things. In the meantime, telemetry jobs are failing. This PR adds a switch to turn all of the telemetry stuff off - to skip it instead. It is meant to be controlled by an org-wide environment variable, which can be applied to individual repos by ops. At the time of submitting this PR, the environment variable is 'false' and no telemetry is being reported.

Authors:
  - Mike Sarahan (https://github.com/msarahan)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1752
  • Loading branch information
msarahan authored Dec 9, 2024
1 parent 8d41610 commit 46b232e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
OTEL_SERVICE_NAME: "pr-rmm"
steps:
- name: Telemetry setup
if: ${{ vars.TELEMETRY_ENABLED == 'true' }}
uses: rapidsai/shared-actions/telemetry-dispatch-stash-base-env-vars@main
changed-files:
needs:
Expand Down Expand Up @@ -142,7 +143,7 @@ jobs:
telemetry-summarize:
runs-on: ubuntu-latest
needs: pr-builder
if: always()
if: ${{ vars.TELEMETRY_ENABLED == 'true' && !cancelled() }}
continue-on-error: true
steps:
- name: Load stashed telemetry env vars
Expand Down

0 comments on commit 46b232e

Please sign in to comment.