Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore healthchecks on exploit files #215

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Ignore healthchecks on exploit files #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/software/metasploit-framework.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def has_windows_metasploit_framework_repo?

# This depends on libfuse
whitelist_file "#{install_dir}/embedded/framework/data/exploits/CVE-2016-4557/hello"
whitelist_file "#{install_dir}/embedded/framework/data/exploits/CVE-2023-0386/cve_2023_0386.x64.elf"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be covered by the above line:

whitelist_file "#{install_dir}//embedded/framework/data/exploits/.*"

Which should be a regex match:

https://github.com/rapid7/omnibus/blob/c6dc312d985e85fb35b8e9f8e49b607abd91665c/lib/omnibus/software.rb#L581

Which is used with match in the health checks:

https://github.com/rapid7/omnibus/blame/r7_9.0.23_custom/lib/omnibus/health_check.rb#L586-L592

But for some reason it's not covered correctly; will land to unblock the deploys working - and if there's time in the future can debug further


# This depends on Openssl 1.x
whitelist_file "#{install_dir}/embedded/lib/ruby/gems/#{ruby_abi_version}/gems/metasploit-payloads.*"
Expand Down
Loading